Tab Mix Plus

do you get the problem with ctrl+tab only when you are using Tab Group Manager?
post your Tabmix and Tab Group Manager settings

_________________
Tab Mix Plus 0.4.1.0
latest Dev-Build
Forum RSS, Troubleshooting

The close tab prompt is showing up twice in Firefox 3.6 when I do the following:

1. Set Firefox to be in private browsing mode from the Tools menu.
2. Set the "Warn me when closing window with multiple tabs" checkbox option in Tab Mix Plus's Tab Closing options.
3. Clear the "Warn me when closing window with multiple tabs" checkbox option in Tab Mix Plus's Tab Closing options.

Once I do that, any time I close the last browser window, I get prompted if I want to close the tabs. If I click "Close Window" I get a 2nd prompt asking the same exact thing. If I click "Close Window" on the second prompt, Firefox 3.6 will exit.



On a related note, in Firefox 3.6, when the last window is closed, if the "browser.tabs.warnOnClose" preference is set Firefox puts up the "Do you want Namoroka to save your tabs for the next time it starts?" prompt with the options to "Save & Quit", "Quit" or "cancel". Tab Mix Plus prevents that window from displaying and instead displays it's own "Close Window" prompt. In Firefox 3.6, Firefox sends a "browser-lastwindow-close-requested" notification when the last browser window is trying to close as opposed to a "quit-application-requested" which is set when the browser is shutting down (see Firefox bug 354894)

The way Tab Mix Plus is currently implementing it's close window prompt is not at all friendly to other addons or even Firefox itself, since it is ignoring the established notifications by overwriting browser functions. For example, in Firefox 3.6 when the last window is about to close a "browser-lastwindow-close-requested" notification is sent out. Any add-on that wants to cancel the close will set the cancel flag to true. This aborts the close. If no one aborts the close then a "browser-lastwindow-close-granted" notification is sent out to inform all listeners that the window will close. It's at this point that Tab Mix Plus puts up it's prompt window, but at that point the browser has already told all the listeners that the last browser window has already closed. This is very bad because listeners will think the last window is closed even if the user presses the cancel button on TMP's prompt.

It would be better to listen for the window "close" event (which fires before the window closes) and/or the "browser-lastwindow-close-granted" notification.

If you really need to modify things, it might be better to create your own warnAboutClosingWindow and then pass that as the second parameter to the gBrowser.closeWindow() function, but be wary that it might force other add-ons to modify TMP to get things to work correctly.

Similar to the issue I reported above, Tab Mix Plus's close window prompt will display after Firefox's Save & Quit prompt if there is a non-browser window open when the last browser window closes.

For example:
1. Open one browser window open containing more than one tab
2. Open the Error Console
3. Close the browser window

Results:
1. Firefox's Quit prompt will display.
2. Once choosing quit or quit and save, Tab Mix Plus's quit prompt will display.

Morac,
do you see this with the latest dev-build?
can you post your TMP settings ?
can you test with the same settings what are the result in Firefox 3.0, 3.5
and 3.71apre?

my goal is to present to the use only ONE warning before closing window with multiply tabs.

so if Firefox puts up the "Do you want Namoroka to save your tabs for the next time it starts?" prompt with the options to "Save & Quit", "Quit" or "cancel". then Tabmix shouldn't puts its own warning event if extensions.tabmix.windows.warnOnClose set to true.

i see the bag that caused TMP to show 2 prompt on private browsing and i will fix that.
anyhow if TMP the cancel the close after "browser-lastwindow-close-granted" i will fix that.

_________________
Tab Mix Plus 0.4.1.0
latest Dev-Build
Forum RSS, Troubleshooting

I have been seeing a problem in the latest builds when I use session restore I always have it ask when I close firefox if I want to keep closed tab list when I click the option to keep it it never does it only keeps the open tab that might want to be looked into.

look at Tabmix options > Session > Preserve
make sure to check Closed tabs list

_________________
Tab Mix Plus 0.4.1.0
latest Dev-Build
Forum RSS, Troubleshooting

FYI: Firefox 3.5.4 breaks TMP 3.8.1! I found out the hard way after upgrading to Firefox 3.5.4. Luckily, though, installing the latest dev version of TMP fixes the problem.

I've also noticed this...

_________________
Tab Mix Plus 0.4.1.0
latest Dev-Build
Forum RSS, Troubleshooting

This bug is still present in latest dev build (0.3.8.2pre.091011)...

Reverting to 0.3.8.1 fixes it, even with the latest TST dev build.

Thanks for the update, onemen.

_________________
Ray
Main OS: Win7 64-bit; Secondary OS: WinXP 32-bit; Using latest TMP Dev builds on Nightly (nee Minefield) Win32 nightlies
Link: TMP Troubleshooting Steps

^ what he said!

_________________
VistaHP/Fx latest beta/TMP latest dev.build/Troubleshooting TMP/My styles

I figured out the problem that I posted earlier about closed tab list not being saved when I do that it is saved but will not show up until I open a tab then closeing it once I do that the closed tab list is shown might want to fix that problem when u get a chance but it won't show the list without opening and closing a tab.

post your Tabmix settings
try to create new clean profile install TMP import you TMP from your current profile. do you get the same behavior ?

_________________
Tab Mix Plus 0.4.1.0
latest Dev-Build
Forum RSS, Troubleshooting

morac, do you use session manager, it has a fix for the issue you mentioned in the latest.

_________________
Tab Mix Plus 0.4.1.0
latest Dev-Build
Forum RSS, Troubleshooting

fix confirmed - thanks onemen!

Tab Mix Plus v0.3.8.2 ????
Tab Mix Plus Dev-Build 0.3.8.2pre.091012 - ok

I'm still seeing the "browser-lastwindow-close-granted" notification go out in Firefox 3.6 and above when the last window is closed, even if the user cancel's TMP "close confirm" prompt. Actually the notification goes out before the prompt even displays. TMP is waiting too late into the close process to put up it's prompt.

Compare this to when TMP is not installed, the "browser-lastwindow-close-granted" notification only goes out if the user actually clicks "QUIT" or "SAVE & QUIT".

Here's the steps to reproduce this in Firefox 3.6 for Windows:

1. Open Firefox so only one browser window is displayed.
2. Open the Error Console
3. Close the Firefox browser window.

Results without TMP installed:
1. A "Quit & Save", "Quit" or "Cancel" dialog is displayed. If the user chooses anything but cancel the "browser-lastwindow-close-granted" notification is dispatched. If "Cancel" is pressed no notification is sent.

Results with TMP 0.3.8.2pre.091012 installed:
1. The "browser-lastwindow-close-granted" notification is dispatched (this kicks off certain shutdown processing). The Firefox quit prompt never displays.
2. The TMP "Confirm close" prompt displays.


I'm not sure why TMP is putting up it's own prompt anyway since Firefox already does so, but it really shouldn't be displaying the "Confirm close" prompt when the last browser window is closing since Firefox already prompts in the instance.

I attached my TMP preferences.

Thanks for the latest update, onemen.

I'm just glad I don't use the extensions that tend not play well together with TMP.

_________________
Ray
Main OS: Win7 64-bit; Secondary OS: WinXP 32-bit; Using latest TMP Dev builds on Nightly (nee Minefield) Win32 nightlies
Link: TMP Troubleshooting Steps