Tab Mix Plus

Official Home of TMP
It is currently Tue May 21, 2013 12:02 pm

All times are UTC - 6 hours [ DST ]




Post new topic Reply to topic  [ 30 posts ]  Go to page 1, 2  Next
Author Message
PostPosted: Sat Sep 11, 2010 12:02 pm 
Offline
Admin

Joined: Wed Aug 03, 2005 1:13 am
Posts: 5194
Location: Rocky Mountains
onemen,

as you might have already noticed, there posts popping up about google opening links in current tab again. Personally, i despise goo and clear cache and dump their cookies after every use, so signing in to change prefs there is not an option. However, it was fixed a while ago and has worked fine (for me) until maybe a couple of updates ago. I don't think it has to do with TMP however, probably goo has changed something again.
In any case, could you please look into this? TIA!

_________________
VistaHP/Fx latest beta/TMP latest dev.build/Troubleshooting TMP/My styles


Top
 Profile  
 
 Post subject:
PostPosted: Sat Sep 11, 2010 1:24 pm 
Offline
Admin
User avatar

Joined: Thu Aug 04, 2005 1:12 pm
Posts: 7288
post your setting that open link in current tab

_________________
Tab Mix Plus 0.4.1.0
latest Dev-Build
Forum RSS, Troubleshooting


Top
 Profile  
 
 Post subject:
PostPosted: Sat Sep 11, 2010 3:09 pm 
Offline
Admin

Joined: Wed Aug 03, 2005 1:13 am
Posts: 5194
Location: Rocky Mountains
I have no such thing! :lol: Everything everywhere, in every ext. i use is always set to new background (when available) tab.
Are you saying you don't see this?


Attachments:
TMPpref.txt [7.93 KiB]
Downloaded 146 times

_________________
VistaHP/Fx latest beta/TMP latest dev.build/Troubleshooting TMP/My styles
Top
 Profile  
 
 Post subject:
PostPosted: Tue Sep 14, 2010 2:25 pm 
Offline
Admin
User avatar

Joined: Thu Aug 04, 2005 1:12 pm
Posts: 7288
i tested new profile + Tabmix + your settings

can you confirm this:

from Firefox search field search for firefox.
the result address is something like:
http://www.google.com/search?q=firefox& ... =firefox-a
then click on links in the result page open new tab.


from address bar open http://www.google.com, search for firefox.
the result address is something like:
http://www.google.com/#hl=iw&source=hp& ... 9204f46b34
click on links in the result page open in the result tab

_________________
Tab Mix Plus 0.4.1.0
latest Dev-Build
Forum RSS, Troubleshooting


Top
 Profile  
 
 Post subject:
PostPosted: Tue Sep 14, 2010 3:55 pm 
Offline
Admin

Joined: Wed Aug 03, 2005 1:13 am
Posts: 5194
Location: Rocky Mountains
Correct. I'm talking about the second case. Notice, it works all right in Fx 3..6.9 (that is opens a new tab for links from the goo search results page).
I believe that's what many complain here about lately (but i wonder if they all use Mf?).

_________________
VistaHP/Fx latest beta/TMP latest dev.build/Troubleshooting TMP/My styles


Top
 Profile  
 
 Post subject:
PostPosted: Tue Sep 14, 2010 5:11 pm 
Offline
Admin
User avatar

Joined: Thu Aug 04, 2005 1:12 pm
Posts: 7288
i see the same in FF 3.6.9 and in Mf

Google inner code in the page interrupt the click event before it reach to Firefox contentAreaClick function.

the workaround is always to open search from Firefox search field or from
http://www.google.com/firefox

for other languages look http://www.google.com/language_tools for proper site and add /firefox at the end of the address

_________________
Tab Mix Plus 0.4.1.0
latest Dev-Build
Forum RSS, Troubleshooting


Top
 Profile  
 
 Post subject:
PostPosted: Tue Sep 14, 2010 5:20 pm 
Offline
Admin

Joined: Wed Aug 03, 2005 1:13 am
Posts: 5194
Location: Rocky Mountains
Sux. One more reason i hate goo and use it very, very, very seldom.
Thanks for getting to the bottom of it, onemen! We now can direct people to this thread, hopefully, it will help others.

_________________
VistaHP/Fx latest beta/TMP latest dev.build/Troubleshooting TMP/My styles


Top
 Profile  
 
 Post subject:
PostPosted: Tue Sep 14, 2010 7:02 pm 
Offline
Admin
User avatar

Joined: Thu Aug 04, 2005 1:12 pm
Posts: 7288
i think i have found a fix

Code:
    gBrowser.mPanelContainer.addEventListener("click", function (aEvent) {
      if (/www\.google/.test(aEvent.target.parentNode.baseURI)) {
        contentAreaClick(aEvent, true);
        aEvent.stopPropagation();
      }
    }, true);


adding this new eventListener can catch the click event before google code and activate contentAreaClick to handle the click.
i do it only for site that starts with www.google

i hope that this not brake any feature in Google

_________________
Tab Mix Plus 0.4.1.0
latest Dev-Build
Forum RSS, Troubleshooting


Top
 Profile  
 
 Post subject:
PostPosted: Wed Sep 15, 2010 12:11 am 
Offline
Admin

Joined: Wed Aug 03, 2005 1:13 am
Posts: 5194
Location: Rocky Mountains
Awesome! Are you going top include it in the next dev.build?

_________________
VistaHP/Fx latest beta/TMP latest dev.build/Troubleshooting TMP/My styles


Top
 Profile  
 
 Post subject:
PostPosted: Wed Sep 15, 2010 10:12 am 
Offline
Admin
User avatar

Joined: Thu Aug 04, 2005 1:12 pm
Posts: 7288
Yes

_________________
Tab Mix Plus 0.4.1.0
latest Dev-Build
Forum RSS, Troubleshooting


Top
 Profile  
 
 Post subject:
PostPosted: Wed Sep 15, 2010 12:25 pm 
Offline
Admin

Joined: Wed Aug 03, 2005 1:13 am
Posts: 5194
Location: Rocky Mountains
Even awesomer Image
Thanks a lot!

_________________
VistaHP/Fx latest beta/TMP latest dev.build/Troubleshooting TMP/My styles


Top
 Profile  
 
 Post subject:
PostPosted: Fri Sep 17, 2010 10:24 am 
Offline
Admin

Joined: Wed Aug 03, 2005 1:13 am
Posts: 5194
Location: Rocky Mountains
With the latest build, 916a, it still opens links in the same tab on goo search results page. This doesn't happen on the results page which opens if you search from Fx searchbar, as you stated above.
So, to sum it up:

1.type forefox in the searchbar/enter
2.in the results page, click the first link - opens in a new tab (with my settings to open everything in new tabs, i.e. lock tabs)
3. now type fox, click the first link in the results page and it will open in the same tab.

I guess this is just one more example of goo's intrusiveness and disrespect for users. I guess they want everybody to sign in 'cause we already know that one can change this in their prefs. I wonder how they're able to get around browser settings though.

_________________
VistaHP/Fx latest beta/TMP latest dev.build/Troubleshooting TMP/My styles


Top
 Profile  
 
 Post subject:
PostPosted: Fri Sep 17, 2010 12:07 pm 
Offline
Admin
User avatar

Joined: Thu Aug 04, 2005 1:12 pm
Posts: 7288
makondo
1. do you type forefox from Firefox search-bar ?
post the address of the result page

2. in the 2nd type do you type fox in the first result page or again in Firefox search-bar. post the address for that result page also

did you see this post http://tmp.garyr.net/forum/viewtopic.php?p=44546#44546

_________________
Tab Mix Plus 0.4.1.0
latest Dev-Build
Forum RSS, Troubleshooting


Top
 Profile  
 
 Post subject:
PostPosted: Fri Sep 17, 2010 2:42 pm 
Offline
Admin

Joined: Wed Aug 03, 2005 1:13 am
Posts: 5194
Location: Rocky Mountains
1. type firefox in the Fx searchbar/enter
2. opens this: http://www.google.com/search?q=firefox& ... =firefox-a
3. click the first link - loads in a new tab.
4. change firefox to fox and enter (at this point you're still at the page linked in #2)
5. in the new results, click any link and it will open in the same tab.


I'm not sure which post you want me to see (the page scrolls to the last post about goo voice) but since i read every one of them i'm pretty sure i've 'seen' that one too :D (what is it about?).

_________________
VistaHP/Fx latest beta/TMP latest dev.build/Troubleshooting TMP/My styles


Top
 Profile  
 
 Post subject:
PostPosted: Fri Sep 17, 2010 3:56 pm 
Offline
Admin
User avatar

Joined: Thu Aug 04, 2005 1:12 pm
Posts: 7288
can you test Google voice ?

i try your link and it open in new tab for me
after you enter fox to the search filed and click enter
what was the result page address ?

_________________
Tab Mix Plus 0.4.1.0
latest Dev-Build
Forum RSS, Troubleshooting


Top
 Profile  
 
 Post subject:
PostPosted: Fri Sep 17, 2010 8:06 pm 
Offline
Admin

Joined: Wed Aug 03, 2005 1:13 am
Posts: 5194
Location: Rocky Mountains
onemen wrote:
can you test Google voice ?

No, sorry.

_________________
VistaHP/Fx latest beta/TMP latest dev.build/Troubleshooting TMP/My styles


Top
 Profile  
 
 Post subject:
PostPosted: Fri Sep 17, 2010 8:08 pm 
Offline
Admin

Joined: Wed Aug 03, 2005 1:13 am
Posts: 5194
Location: Rocky Mountains
After i enter fox:
http://www.google.com/search?q=firefox& ... e2c08f8b07

Notice, as i said, it only happens in Mf nighlies and Fx 4.0beta. My 3.6.10 works perfectly fine. Just tested again in a clean Mf profile, TMP only installed and my settings (which i import everywhere so they're the same everywhere).

_________________
VistaHP/Fx latest beta/TMP latest dev.build/Troubleshooting TMP/My styles


Top
 Profile  
 
 Post subject:
PostPosted: Sat Sep 18, 2010 5:58 am 
Offline
Admin
User avatar

Joined: Thu Aug 04, 2005 1:12 pm
Posts: 7288
links from that search open for me in a new tab

I'm going to Backout that code to block Google site code.

i will try to find better solution.

_________________
Tab Mix Plus 0.4.1.0
latest Dev-Build
Forum RSS, Troubleshooting


Top
 Profile  
 
 Post subject:
PostPosted: Sat Sep 18, 2010 10:47 am 
Offline
Admin

Joined: Wed Aug 03, 2005 1:13 am
Posts: 5194
Location: Rocky Mountains
Mystery! You didn't set Goo prefs to open links in new tabs by any chance?
BTW, i see this in 3.6.10 too now.

_________________
VistaHP/Fx latest beta/TMP latest dev.build/Troubleshooting TMP/My styles


Top
 Profile  
 
 Post subject:
PostPosted: Sun Sep 19, 2010 10:53 am 
Offline

Joined: Sat Jan 07, 2006 1:31 am
Posts: 15
With respect to this problem, I see the behavior you describe (links open in same page with the second search) if Google's "instant" feature is "on." If "instant" is "off," links open as they used to.

So I'm just turning Google's "instant" setting off. I don't care for that feature anyway.

I usually use either the Google toolbar or iGoogle and only sometimes the classic Google page -- which is where "instant" is implemented. And I use those three almost interchangeably, so it could be that is why the problem appeared intermittent to me. I'll watch and see if that solves all of my problems with opening links in the same tab.

It is clear though that this does not seem to be related to the missing "locked" icon. That seems really intermittent. In some Firefox sessions the locked item is present and in others it is not.


Top
 Profile  
 
Display posts from previous:  Sort by  
Post new topic Reply to topic  [ 30 posts ]  Go to page 1, 2  Next

All times are UTC - 6 hours [ DST ]


Who is online

Users browsing this forum: No registered users and 4 guests


You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot post attachments in this forum

Search for:
Jump to:  
Powered by phpBB® Forum Software © phpBB Group