Tab Mix Plus

Official Home of TMP
It is currently Thu May 23, 2013 5:49 pm

All times are UTC - 6 hours [ DST ]




Post new topic This topic is locked, you cannot edit posts or make further replies.  [ 3278 posts ]  Go to page Previous  1 ... 128, 129, 130, 131, 132, 133, 134 ... 164  Next
Author Message
PostPosted: Mon Mar 28, 2011 10:27 pm 
Offline

Joined: Mon Mar 28, 2011 9:53 pm
Posts: 19
I'm the developer of the Firefox theme Classic Compact, mentioned above. I've been working through the conflicts between Classic Compact and TabMix+. The short version of the problem is that TMP is collapsing my tabs shorter than intended.

I've been working through a series of tests to narrow down what is causing the problem and the best I can tell, TabMix+, either intentionally or unintentionally is negating/breaking any "min-height" and "height" css rules I apply to the DOM object "tab" class "tabbrowser-tab". When TMP is disabled these rules work just fine, when TMP is enabled they totally get ignored by Firefox. I've looked at the style rules for this object using DOM Inspector and the best I can tell this isn't an issue of TMP overwriting my CSS rules with rules of its own, rather Firefox just stops obeying "min-height" rules for tabs.

I understand there are some Classic Compact specific fixes pending in TMP to address tab height issues. PLEASE DO NOT DO THIS IT WILL MAKE MATTERS WORSE!!! Specifically I saw some height and margin rules, which will defeat what I'm trying to accomplish with Classic Compact and will result in me getting complaints from TMP users about stray borders and excess tab height.

My next Classic Compact build has been tested extensively against TMP v0.3.8.5 on FF4 and while there are still some tab height issues, I have been able to minimize them, provided you don't use CSS rules that target Classic Compact explicitly.

What really needs to be done is to figure out why TMP is breaking the "min-height" rule for tabs and fix this instead of writing theme specific fixes.

If I could rely on the min-height rule for tabs even when TMP was enabled the compatibility issues between TMP and Classic Compact would be greatly reduced.


Top
 Profile  
 
 Post subject:
PostPosted: Mon Mar 28, 2011 10:52 pm 
Offline
Admin

Joined: Wed Aug 03, 2005 1:13 am
Posts: 5194
Location: Rocky Mountains
Interesting.
I have more than a dozen of styles for tabs and never had a problem making them high or tall as i'd wish.

_________________
VistaHP/Fx latest beta/TMP latest dev.build/Troubleshooting TMP/My styles


Top
 Profile  
 
 Post subject:
PostPosted: Mon Mar 28, 2011 11:35 pm 
Offline

Joined: Mon Mar 28, 2011 9:53 pm
Posts: 19
makondo wrote:
Interesting.
I have more than a dozen of styles for tabs and never had a problem making them high or tall as i'd wish.


I spent hours on this issue alone today, testing, testing, testing. It boiled down to I would specify a "min-height" as so:
Code:
.tabbrowser-tab,
.tabs-newtab-button {min-height:17px !important}


It would work beautifully in Firefox UNTIL I enabled TMP. When TMP was activated, the height of those objects would collapse down to a much shorter height. I looked in the DOM Inspector and found no CSS instructions from TabMix+ that were assigning a min-height to the above mentioned classes. This leads me to believe that TMP is doing something that the DOM Inspector can't see (e.g. causing FF to ignore min-height rules for these classes).

I spent hours today massaging child objects inside of tabs until I got TMP to at least give me a little more height, while not mucking up the bottom border of my tabs when TMP was disabled. I also had to raise the height of the tab label text so that it wouldn't get cropped by the tabs being too short in TMP.

This was a real balancing act because the bottom border needs to disappear for the active tab, which means the active tab needs to overflow the tab-strip such that the active tab's background gradient covers up the bottom border of the tab strip. Overall, the tabs are probably more robust now, and they are within 2px of being correct in TMP but they still aren't perfect.[/code]


Top
 Profile  
 
 Post subject:
PostPosted: Mon Mar 28, 2011 11:46 pm 
Offline
Admin

Joined: Wed Aug 03, 2005 1:13 am
Posts: 5194
Location: Rocky Mountains
I see, thanks. onemen should show up soon and hopefully you two will work out something useful.

_________________
VistaHP/Fx latest beta/TMP latest dev.build/Troubleshooting TMP/My styles


Top
 Profile  
 
 Post subject:
PostPosted: Tue Mar 29, 2011 1:31 am 
Offline

Joined: Mon Mar 28, 2011 9:53 pm
Posts: 19
makondo wrote:
I see, thanks. onemen should show up soon and hopefully you two will work out something useful.


The latest build of Classic Compact is at http://environmentalchemistry.com/class ... .0.0b1.jar

It was updated about one hour ago. In testing against TMP v0.3.8.5 it is now doing much better. I'm not happy with the multi-row presentation, but the single row presentation is only off by a pixel or two and is not overly noticeable. Certainly it is livable. I'd still like to know why min-height doesn't work. That could have saved hours of work.


Top
 Profile  
 
 Post subject:
PostPosted: Tue Mar 29, 2011 2:10 am 
Offline
Admin
User avatar

Joined: Thu Aug 04, 2005 1:12 pm
Posts: 7295
klb wrote:
makondo wrote:
I see, thanks. onemen should show up soon and hopefully you two will work out something useful.


The latest build of Classic Compact is at http://environmentalchemistry.com/class ... .0.0b1.jar

It was updated about one hour ago. In testing against TMP v0.3.8.5 it is now doing much better. I'm not happy with the multi-row presentation, but the single row presentation is only off by a pixel or two and is not overly noticeable. Certainly it is livable. I'd still like to know why min-height doesn't work. That could have saved hours of work.


klb, thank you to bring this information to my intention.
i will remove css rules that are relating to Classic Compact:
Code:
.tabbrowser-tabs[tabmix_skin="classiccompact"]:not([multibar])[inline=true] .tabbrowser-arrowscrollbox > .tabs-newtab-button,
.tabbrowser-tabs[tabmix_skin="classiccompact"][multibar] .tabbrowser-arrowscrollbox > .tabs-newtab-button {
  height: 18px !important;
  max-height: 18px !important;
  margin: 0px !important;
}

.tabbrowser-tabs[tabmix_skin="classiccompact"][multibar] > .tabbrowser-tab {
  height: 18px;
  max-height: 18px;
  margin: 0px 0px 0px;
}

.tabbrowser-tabs[tabmix_skin="classiccompact"][multibar] .tabs-frame {
  margin-top: 1px;
  margin-bottom: 2px;
}


regarding min-height can you check if deleting this rules from tabmix tab.css change somthing?.
Code:
.tabbrowser-tabs[flowing=multibar][multibar=scrollbar] .tabbrowser-tab {
  min-height: 0px !important;
  min-width: 0px !important;
}


the best way is always work together, it saves time to all of us developers

_________________
Tab Mix Plus 0.4.1.0
latest Dev-Build
Forum RSS, Troubleshooting


Top
 Profile  
 
 Post subject:
PostPosted: Tue Mar 29, 2011 8:22 am 
Offline

Joined: Mon Mar 28, 2011 9:53 pm
Posts: 19
I removed it the two style rules you requested and it had no impact. I'm not sure why you would put them in to begin with.

I'm beginning to think the min-height issue might be deeper bug in Firefox. The trick is for me to isolate down exactly how to expose the bug so that I can document it in Bugzilla. One of the first steps is to figure out how to rule out TMP.

It wouldn't be the first Firefox bug I've exposed while working on some version of Classic Compact. With FF3.0 I somehow managed to trip over a critical security bug. Oftentimes theme related cosmetic bugs languish but boy did that one get patched quick!

I'm now trying to tackle multi-row tabs to see how I can refine them a little bit. As soon as I have working code I'll let you know. What I'd like to know is how does the height of a multi-row tabs box (#tabbrowser-tabs) get determined? I can't find any style rules using DOM Inspector that would justify its height. It looks like some piece of programming dictates the tabs box height based on the number of rows. It would be nice if the height could be dynamically effected based on the cumulative height of containing objects. Right now my tabs end up with a bunch of white space below the last row because they are so much shorter than the default theme tabs.


Top
 Profile  
 
 Post subject:
PostPosted: Tue Mar 29, 2011 9:03 am 
Offline

Joined: Mon Mar 28, 2011 9:53 pm
Posts: 19
Based on the build of Classic Compact I linked to above and TMP0.3.8.5, my adding the following code to my browser.css file seems to greatly improve the look of multi-row tabs:

Code:
/* Tab Mix Plus multi-bar adjustments */

.tabbrowser-tabs[flowing=multibar][multibar] .tabbrowser-tab,
.tabbrowser-tabs[flowing=multibar][multibar] .tabs-newtab-button{
  vertical-align: top !important;
  margin:2px 0 0px !important;
  background-position: 0px 1px;
}

.tabbrowser-tabs[flowing=multibar][multibar] .tabbrowser-tab[selected="true"]{
  border-bottom-width:0;
  margin-bottom:-1px !important;
}

"Vertical-align:top" was required because the bottom margin of my selected tabs is different from the margin of other tabs. This was causing alignment issues when vertical-align was set to bottom.

---EDIT---
I've uploaded a new test version of Classic Compact that seems to address TMP issues (including multi-row) to a satisfactory level at least for v0.3.8.5. It can downloaded from: http://environmentalchemistry.com/class ... .0.0b1.jar


Top
 Profile  
 
 Post subject:
PostPosted: Tue Mar 29, 2011 10:29 am 
Offline
User avatar

Joined: Fri Jul 06, 2007 7:05 pm
Posts: 736
Location: Columbus, OH
Have you all checked out Bug #570279 [Firefox:Theme]-Tab+NavBar Connecting Curve Adjustments [Win]?

It was a tab theme change made fairly late in the development of Fx 4 that among other changes also, I believe, increased the height of the tabs. I cannot say, though, that it significantly changes tabs compared to how they were handled in Fx 3.x.

_________________
Ray
Main OS: Win7 64-bit; Secondary OS: WinXP 32-bit; Using latest TMP Dev builds on Nightly (nee Minefield) Win32 nightlies
Link: TMP Troubleshooting Steps


Top
 Profile  
 
 Post subject:
PostPosted: Tue Mar 29, 2011 10:36 am 
Offline
Admin
User avatar

Joined: Thu Aug 04, 2005 1:12 pm
Posts: 7295
klb

its better to set margin-top 1px and margin-bottom 1xp then margin-top 2px.
with your css all the tabs move 1px down when entring the 2nd row

also you need to set button size to 17px to prevent the button from shift down when in multi-row

Code:
/* Tab Mix Plus multi-bar adjustments */
.tabbrowser-tabs[flowing=multibar][multibar] .tabbrowser-tab,
.tabbrowser-tabs[flowing=multibar][multibar] .tabs-newtab-button{
  vertical-align: top !important;
  margin:1px 0 1px !important;
  background-position: 0px 1px;
}

.tabbrowser-tabs[flowing=multibar][multibar] .tabbrowser-tab[selected="true"]{
  border-bottom-width:0;
  margin-bottom:-1px !important;
}

#TabsToolbar[multibar] > .toolbarbutton-1,
#TabsToolbar[multibar] > #tabs-closebutton {
  height: 17px !important;
}

_________________
Tab Mix Plus 0.4.1.0
latest Dev-Build
Forum RSS, Troubleshooting


Top
 Profile  
 
 Post subject:
PostPosted: Tue Mar 29, 2011 11:23 am 
Offline

Joined: Mon Mar 28, 2011 9:53 pm
Posts: 19
WildcatRay wrote:
Have you all checked out Bug #570279 [Firefox:Theme]-Tab+NavBar Connecting Curve Adjustments [Win]?

It was a tab theme change made fairly late in the development of Fx 4 that among other changes also, I believe, increased the height of the tabs. I cannot say, though, that it significantly changes tabs compared to how they were handled in Fx 3.x.


I don't know what they are smoking using a image file to create radius borders. That was causing me numerous headaches so I went back to the old style way of doing borders yesterday. It cleared up a bunch of problems really fast. You know old school like:
Code:
  border-top: 1px solid;
  border-right: 1px solid;
  border-left: 1px solid;
  border-bottom: 0px solid ThreeDHighlight;
  -moz-border-top-colors: ThreeDHighlight ThreeDLightShadow;
  -moz-border-right-colors: ThreeDDarkShadow ThreeDShadow;
  -moz-border-left-colors: ThreeDHighlight ThreeDLightShadow;
  border-top-left-radius: 3px;
  border-top-right-radius: 3px;


Don't like the radius simply change it to the number you want. Why are they pushing us towards gradient backgrounds without using image files and then turn around and use an image file for borders? :roll:


Top
 Profile  
 
 Post subject:
PostPosted: Tue Mar 29, 2011 11:26 am 
Offline
Admin

Joined: Wed Aug 03, 2005 1:13 am
Posts: 5194
Location: Rocky Mountains
Uhmm, guys, since this is a display issue, please, carry on in the Display Issues thread. Thanks!

_________________
VistaHP/Fx latest beta/TMP latest dev.build/Troubleshooting TMP/My styles


Top
 Profile  
 
 Post subject:
PostPosted: Tue Mar 29, 2011 11:32 am 
Offline

Joined: Mon Mar 28, 2011 9:53 pm
Posts: 19
@onemen,

Could you please pull the Classic Compact targeted fixes out of 0.3.8.6pre? I have Classic Compact working correctly tab height wise on 0.3.8.5 but your targets are messing me up on 0.3.8.6pre.

I do have the proper min-heights and margins in the proper places for what I want to accomplish. I'm moving tabs down one pixel to cover the tabs box border on the bottom row. It works quite nice in 0.3.8.5


Top
 Profile  
 
 Post subject:
PostPosted: Thu Mar 31, 2011 6:34 pm 
Offline

Joined: Mon Mar 28, 2011 9:53 pm
Posts: 19
rado84 wrote:
Also, if not a problem, can you add an option to resize tab's height?

I'm just finishing up redeveloping my theme Classic Compact for FF4 and a huge amount of my time was spent on getting tabs to display correct. I will tell you that dealing with tab heights is exceedingly difficult to get right. Literally, tuning tab height is like building a house of cards.

It wouldn't be impossible for these guys to create an option to adjust tab heights but if they did and they didn't blow up custom themes along the way they would deserve some major $$ donations for their effort.


Top
 Profile  
 
 Post subject:
PostPosted: Thu Mar 31, 2011 9:19 pm 
Offline
Admin

Joined: Wed Aug 03, 2005 1:13 am
Posts: 5194
Location: Rocky Mountains
Once again Image
makondo wrote:
Are we going to do this on every page?!
makondo wrote:
PAY ATTENTION, people!

There's a nice new sticky for display issues. Please, post all and only DISPLAY related stuff there. With screenshots! Don't forget your OS, Fx and TMP versions....
Let's keep it clean, well organized and easy for onemen and others to follow and find stuff around here.

Thanks for your cooperation!

_________________
VistaHP/Fx latest beta/TMP latest dev.build/Troubleshooting TMP/My styles


Top
 Profile  
 
 Post subject:
PostPosted: Fri Apr 01, 2011 2:29 am 
Offline

Joined: Mon Nov 15, 2010 4:24 am
Posts: 7
makondo wrote:
Once again (...)

Sorry, man. I didn't know about the other topic. I found this one after hours of Googling and it didn't cross my mind that there might be a display topic. :oops:

klb wrote:
Literally, tuning tab height is like building a house of cards.

:shock: I never thought it would be so hard.


Top
 Profile  
 
 Post subject:
PostPosted: Fri Apr 01, 2011 2:07 pm 
Offline
Admin
User avatar

Joined: Thu Aug 04, 2005 1:12 pm
Posts: 7295
Tab Mix Plus Dev-Build 0.3.8.6pre.110401b Released (Older builds)
  • Fixed: Part of last tab is some times hidden by the scroll button. [Firefox 4.0]
  • Fixed: Incompatibility with extensions - Statues 4 ever, Webmail Notifier, FireGestures and more...
  • Fixed: Incompatibility with themes - Classic compact, BlackFox_V1-Blue.
  • Fixed: JetPack extensions are not working when Tabmix Session Manager enable.
  • Fixed: Ctrl-tab Popup list isn't working as expected when there are hidden tabs (groups). [Firefox 4.0]
  • Fixed: Export sessions to Session Manager extension.
  • Fixed: App tabs override when opening bookmarks groups.
  • Fixed: Links from About Firefox window doesn't open. [Mac]
  • Added: new option in Firefox 4.0 - Prevent double click on Tab-bar from changing window size.
  • Added: Bookmark this tabs to tab context menu. [Firefox 4.0]

_________________
Tab Mix Plus 0.4.1.0
latest Dev-Build
Forum RSS, Troubleshooting


Top
 Profile  
 
 Post subject:
PostPosted: Fri Apr 01, 2011 3:46 pm 
Offline

Joined: Thu Oct 30, 2008 3:05 pm
Posts: 8
Problem in current build and Tree Style Tab 0.11.2011032401 shown below:

Image


Last edited by john12ik2 on Fri Apr 01, 2011 5:13 pm, edited 3 times in total.

Top
 Profile  
 
 Post subject:
PostPosted: Fri Apr 01, 2011 4:18 pm 
Offline
User avatar

Joined: Fri Jul 06, 2007 7:05 pm
Posts: 736
Location: Columbus, OH
Thanks, onemen.

_________________
Ray
Main OS: Win7 64-bit; Secondary OS: WinXP 32-bit; Using latest TMP Dev builds on Nightly (nee Minefield) Win32 nightlies
Link: TMP Troubleshooting Steps


Top
 Profile  
 
 Post subject:
PostPosted: Fri Apr 01, 2011 4:43 pm 
Offline
Admin
User avatar

Joined: Thu Aug 04, 2005 1:12 pm
Posts: 7295
john12ik2 wrote:
Problem in current build and Tree Style Tab


you can add this to your userChrome.css file
Code:
.tab-progress {
  height: 3px;
  margin: -2px 0 -1px;
}


also report about this to TST developer, maybe he will add support for progress meter on tabs to TST.

_________________
Tab Mix Plus 0.4.1.0
latest Dev-Build
Forum RSS, Troubleshooting


Top
 Profile  
 
Display posts from previous:  Sort by  
Post new topic This topic is locked, you cannot edit posts or make further replies.  [ 3278 posts ]  Go to page Previous  1 ... 128, 129, 130, 131, 132, 133, 134 ... 164  Next

All times are UTC - 6 hours [ DST ]


Who is online

Users browsing this forum: No registered users and 1 guest


You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot post attachments in this forum

Search for:
Jump to:  
Powered by phpBB® Forum Software © phpBB Group