Tab Mix Plus

Official Home of TMP
It is currently Sat May 25, 2013 8:07 am

All times are UTC - 6 hours [ DST ]




Post new topic This topic is locked, you cannot edit posts or make further replies.  [ 3278 posts ]  Go to page Previous  1 ... 139, 140, 141, 142, 143, 144, 145 ... 164  Next
Author Message
PostPosted: Thu Jul 14, 2011 3:29 pm 
Offline
User avatar

Joined: Thu May 13, 2010 2:49 pm
Posts: 65
For those of you who don't want to miss the new stuff and still want the JSON stuff to work I have replaced all usage of nsIJSON in TMP latest dev build with the native JSON stuff: http://segaja.de/stuff/tab_mix_plus-dev-build.xpi

So if you don't use any addons that overwrite the native JSON (I hope the addons which do this are blacklisted somewhere for it) you won't have a problem.

Best regards
Segaja

_________________
My firefox addons
Running latest nightly build on Archlinux 32bit


Top
 Profile  
 
PostPosted: Thu Jul 14, 2011 8:31 pm 
Offline

Joined: Thu Jul 14, 2011 8:26 pm
Posts: 6
Segaja wrote:
So if you don't use any addons that overwrite the native JSON ...


Any suggestions on how we check this please? What code are we looking for?


Thanks for the patched build. :)


Top
 Profile  
 
PostPosted: Fri Jul 15, 2011 3:57 am 
Offline
User avatar

Joined: Thu May 13, 2010 2:49 pm
Posts: 65
Hm, it would be some code that redefine the JSON object.

I didn't check my addons. I just tried it and it worked for me.
I know for example that vimperator, adblock plus and session manager don't do it because I saw in there changelog that they also moved to native JSON.

_________________
My firefox addons
Running latest nightly build on Archlinux 32bit


Top
 Profile  
 
PostPosted: Fri Jul 15, 2011 7:50 am 
Offline

Joined: Thu Jul 14, 2011 8:26 pm
Posts: 6
OK, I've no idea how to find that - but I've been running for several hours now with my 24 addons and no problems so far.


Top
 Profile  
 
PostPosted: Fri Jul 15, 2011 8:36 am 
Offline

Joined: Mon Apr 05, 2010 5:56 pm
Posts: 86
Great job Segaja, I have ~90 addons and apparently no one is overwriting the JSON stuff.

Finally I can restore closed tabs. Onemen back from vacation and release this xpi as new build.

And thank you LouCypher, your code is working fine! I felt an orphan without this feature.


Top
 Profile  
 
PostPosted: Fri Jul 15, 2011 11:55 pm 
Offline

Joined: Sat Jul 09, 2011 2:01 pm
Posts: 8
LouCypher wrote:
Karl wrote:
Tried replacing that command, didn't work, then replacing the whole file, the address bar disappeared.

This is the code I'm using
.....
You can use Custom Buttons (in "Initializations" tab) or userChromeJS.

Thanks! this code + custom buttons fixed the issue, the only problem now is that the tab created isn't focused, even when on options i have all "focus/select" options checked, but at least it works now, thanks again.

Regards, Karl.


Top
 Profile  
 
PostPosted: Sat Jul 16, 2011 8:53 am 
Offline

Joined: Sat Jul 16, 2011 8:51 am
Posts: 6
Segaja wrote:
For those of you who don't want to miss the new stuff and still want the JSON stuff to work I have replaced all usage of nsIJSON in TMP latest dev build with the native JSON stuff: http://segaja.de/stuff/tab_mix_plus-dev-build.xpi

So if you don't use any addons that overwrite the native JSON (I hope the addons which do this are blacklisted somewhere for it) you won't have a problem.

Best regards
Segaja


Thank you Segaja. Sadly it only works under Windows 7 and not under Linux (OpenSuse 11.4).
Image


Top
 Profile  
 
PostPosted: Sat Jul 16, 2011 10:13 am 
Offline
User avatar

Joined: Thu May 13, 2010 2:49 pm
Posts: 65
gandharva wrote:
Segaja wrote:
For those of you who don't want to miss the new stuff and still want the JSON stuff to work I have replaced all usage of nsIJSON in TMP latest dev build with the native JSON stuff: http://segaja.de/stuff/tab_mix_plus-dev-build.xpi

So if you don't use any addons that overwrite the native JSON (I hope the addons which do this are blacklisted somewhere for it) you won't have a problem.

Best regards
Segaja


Thank you Segaja. Sadly it only works under Windows 7 and not under Linux (OpenSuse 11.4).
Image


Huh?

It works for me linux (Archlinux 32bit) with the firefox 8 nightlies..

_________________
My firefox addons
Running latest nightly build on Archlinux 32bit


Top
 Profile  
 
PostPosted: Sat Jul 16, 2011 10:33 am 
Offline

Joined: Thu Jul 14, 2011 8:26 pm
Posts: 6
gandharva wrote:
Sadly it only works under Windows 7 and not under Linux (OpenSuse 11.4).


That's not due to the JSON patch - it's due to some other TMP compatibility issue with the 20110716 nightly build. It happens on W7 as well. I've reverted to 20110715 and all works OK.


Top
 Profile  
 
PostPosted: Sat Jul 16, 2011 10:46 am 
Offline

Joined: Sat Jul 16, 2011 8:51 am
Posts: 6
Win7 nightly was from yesterday. Seems TMP completely broke with todays nightly builds... :(


Top
 Profile  
 
PostPosted: Sat Jul 16, 2011 10:57 am 
Offline
User avatar

Joined: Thu May 15, 2008 5:46 am
Posts: 204
Location: Roanoke, Va
TMP was working with the nightly from the 110303a build. About yesterday it seemed it broke some more.

I reverted back to this build:
http://ftp.mozilla.org/pub/mozilla.org/ ... 310724478/

with TMP 110303a and it seems fine.

Ill wait for onemen to return (new build) before updating much more.

_________________
Log home progress - Updated 08/29/2012

Scuba Diving Site

Dell XPS One - Vista Home Premium w/SP2
Mozilla/5.0 (Windows NT 6.0; rv:2.0b6pre) Firefox® Nightly unless otherwise specified
TMP - latest Dev-Build


Top
 Profile  
 
PostPosted: Sat Jul 16, 2011 8:52 pm 
Offline

Joined: Mon Apr 05, 2010 5:56 pm
Posts: 86
Karl wrote:
Thanks! this code + custom buttons fixed the issue, the only problem now is that the tab created isn't focused, even when on options i have all "focus/select" options checked, but at least it works now, thanks again.

Regards, Karl.


Change this part of code to false as bellow:

Quote:
....
if (aTriggeringEvent &&
aTriggeringEvent.altKey &&
!isTabEmpty(gBrowser.selectedTab)) {
this.handleRevert();
content.focus();
gBrowser.loadOneTab(url, {
postData: postData,
inBackground: false,
allowThirdPartyFixup: true});
aTriggeringEvent.preventDefault();
aTriggeringEvent.stopPropagation();
} else {
loadCurrent();
}
....


I prefer to open new tab in foreground also.


Top
 Profile  
 
PostPosted: Sun Jul 17, 2011 3:34 am 
Offline
User avatar

Joined: Wed Mar 30, 2011 6:37 pm
Posts: 36
Segaja wrote:
For those of you who don't want to miss the new stuff and still want the JSON stuff to work I have replaced all usage of nsIJSON in TMP latest dev build with the native JSON stuff: http://segaja.de/stuff/tab_mix_plus-dev-build.xpi

So if you don't use any addons that overwrite the native JSON (I hope the addons which do this are blacklisted somewhere for it) you won't have a problem.

Best regards
Segaja

The patched version above apparently broke on Nightly builds 20110716.

Luckily Chris found a solution mentioned here: http://forums.mozillazine.org/viewtopic ... #p11032559

I combined Chris's nsiDOMwindow fix with Segaja Unofficial Patched Dev TMP build above to make Segaja/Chris Unofficial V2 Patched Dev TMP build and uploaded it here: http://www.mediafire.com/?24b1wirf8ahm4b6, I've tested it on latest Aurora 7.0a2 & Nightly 8.0a1 Win32 20110716 builds and have not seen any problems so far.

Thanks Chris for this needed fix...


Last edited by rob64rock on Sun Jul 17, 2011 6:15 am, edited 1 time in total.

Top
 Profile  
 
PostPosted: Sun Jul 17, 2011 4:42 am 
Offline
User avatar

Joined: Thu May 13, 2010 2:49 pm
Posts: 65
Hm strange,

my build works fine on linux so this other problem must be windows only.

Best regards
Segaja

P.S.: My name is not Seraja ;)

_________________
My firefox addons
Running latest nightly build on Archlinux 32bit


Top
 Profile  
 
PostPosted: Sun Jul 17, 2011 5:42 am 
Offline

Joined: Sat Jul 16, 2011 8:51 am
Posts: 6
rob64rock wrote:
I combined Chris's nsiDOMwindow fix with Seraja Unofficial Patched Dev TMP build above to make Seraja/Chris Unofficial V2 Patched Dev TMP build and uploaded it here: http://www.mediafire.com/?24b1wirf8ahm4b6, I've tested it on latest Aurora 7.0a2 & Nightly 8.0a1 Win32 20110716 builds and have not seen any problems so far.

Thank you very much! This version runs fine under Linux and Windows nightlys from yesterday.


Top
 Profile  
 
PostPosted: Sun Jul 17, 2011 3:31 pm 
Offline

Joined: Mon Apr 05, 2010 5:56 pm
Posts: 86
I changed the LouCypher code a little to open new tab next to current one, here is:

Code:
function handleCommand(aTriggeringEvent) {
  if (aTriggeringEvent instanceof MouseEvent && aTriggeringEvent.button == 2)
    return; // Do nothing for right clicks

  var url = this.value;
  var mayInheritPrincipal = false;
  var postData = null;

  var action = this._parseActionUrl(url);
  if (action) {
    url = action.param;
    if (this.hasAttribute("actiontype")) {
      if (action.type == "switchtab") {
        this.handleRevert();
        let prevTab = gBrowser.selectedTab;
        if (switchToTabHavingURI(url) &&
            isTabEmpty(prevTab))
          gBrowser.removeTab(prevTab);
      }
      return;
    }
  }
  else {
    [url, postData, mayInheritPrincipal] = this._canonizeURL(aTriggeringEvent);
    if (!url)
      return;
  }

  this.value = url;
  gBrowser.userTypedValue = url;
  try {
    addToUrlbarHistory(url);
  } catch (ex) {
    // Things may go wrong when adding url to session history,
    // but don't let that interfere with the loading of the url.
    Cu.reportError(ex);
  }

  function loadCurrent() {
    let flags = Ci.nsIWebNavigation.LOAD_FLAGS_ALLOW_THIRD_PARTY_FIXUP;
    // Pass LOAD_FLAGS_DISALLOW_INHERIT_OWNER to prevent any loads from
    // inheriting the currently loaded document's principal, unless this
    // URL is marked as safe to inherit (e.g. came from a bookmark
    // keyword).
    if (!mayInheritPrincipal)
      flags |= Ci.nsIWebNavigation.LOAD_FLAGS_DISALLOW_INHERIT_OWNER;
    gBrowser.loadURIWithFlags(url, flags, null, null, postData);
  }

  if (aTriggeringEvent instanceof MouseEvent) {
    // We have a mouse event (from the go button), so use the standard
    // UI link behaviors
    let where = whereToOpenLink(aTriggeringEvent, false, false);
    if (where == "current") {
      loadCurrent();
    } else {
      this.handleRevert();
      content.focus();
      openUILinkIn(url, where,
                   { allowThirdPartyFixup: true, postData: postData });
    }
    return;
  }

  if (aTriggeringEvent &&
      aTriggeringEvent.altKey &&
      !isTabEmpty(gBrowser.selectedTab)) {
    this.handleRevert();
    content.focus();
   var currTab=gBrowser.mCurrentTab;
    var newTab = gBrowser.loadOneTab(url, {
                        postData: postData,
                        inBackground: false,
                        allowThirdPartyFixup: true
                  });
   gBrowser.moveTabTo(newTab, currTab._tPos+1);
    aTriggeringEvent.preventDefault();
    aTriggeringEvent.stopPropagation();
  } else {
    loadCurrent();
  }

  gBrowser.selectedBrowser.focus();

}

gURLBar.handleCommand_TMP = gURLBar.handleCommand; // you can skip this line
gURLBar.handleCommand = handleCommand;


ps: someone tried the last version of Tab Utilities addon? Wow! This thing is a real clone of TMP without bugs, I'm thinking about changing addon. Last time I tried tab utilities it was so featureless...


Top
 Profile  
 
PostPosted: Sun Jul 17, 2011 4:42 pm 
Offline
User avatar

Joined: Sat Oct 15, 2005 4:31 pm
Posts: 63
Location: Anglesey, North Wales
testebr wrote:
ps: someone tried the last version of Tab Utilities addon? Wow! This thing is a real clone of TMP without bugs, I'm thinking about changing addon. Last time I tried tab utilities it was so featureless...

I agree, last time I tried it out it was so basic, it's changed a helluvalot. I'll give it a whirl, everyone's speaking JS here anyway!!

_________________
Cheers,
Keith


Top
 Profile  
 
PostPosted: Sun Jul 17, 2011 7:43 pm 
Offline
Admin

Joined: Wed Aug 03, 2005 1:13 am
Posts: 5194
Location: Rocky Mountains
It's a really good ext., light and fast. ithinc is doing a really good job there! However ...
i personally keep coming back to TMP. It just has everything i need, easily customizable to my exact needs and for the most part troublesome. I do have a couple of issues lately but they're not life threatening for me to switch to anything else: renaming doesn't always hold and new tabs pop on downloads. That's in Fx6b2 (and below).

You guys are talking about Fx8 and nightlies as if it's do or die for TMP.
onemen hasn't been around much lately and it *usually* indicates he's working on a release fixing bugs. You might have noticed he's not a 'talker'.

_________________
VistaHP/Fx latest beta/TMP latest dev.build/Troubleshooting TMP/My styles


Top
 Profile  
 
PostPosted: Mon Jul 18, 2011 7:44 pm 
Offline

Joined: Wed Jul 11, 2007 9:15 pm
Posts: 40
Aurora 7.0a2
Mac OS 10.6.8

Since upgrading to 7.0a2 my TMPpref's are not working and when I go to alter all of them manually I get the following error message:

Unresponsive script
chrome://tabmixplus/content/pref/pref-appearance.xml:168

Cheers


Top
 Profile  
 
PostPosted: Mon Jul 18, 2011 10:40 pm 
Offline

Joined: Thu Feb 28, 2008 5:35 pm
Posts: 21
Using the Dev build of TMP and the closed tab list is always empty in Aurora 7a2.


Top
 Profile  
 
Display posts from previous:  Sort by  
Post new topic This topic is locked, you cannot edit posts or make further replies.  [ 3278 posts ]  Go to page Previous  1 ... 139, 140, 141, 142, 143, 144, 145 ... 164  Next

All times are UTC - 6 hours [ DST ]


Who is online

Users browsing this forum: No registered users and 1 guest


You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot post attachments in this forum

Search for:
Jump to:  
Powered by phpBB® Forum Software © phpBB Group